Skip to content

[cifmw_setup] Add default value of cifmw_architecture_repo #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amartyasinha wants to merge 1 commit into from
Closed

[cifmw_setup] Add default value of cifmw_architecture_repo #3475

amartyasinha wants to merge 1 commit into from

Conversation

@amartyasinha
Copy link
Contributor

@amartyasinha amartyasinha commented Nov 12, 2025

Since cifmw_setup role is often used in playbooks outside of ci-framework, it causes group_vars to not be included and causing missing variables error.

@amartyasinha amartyasinha requested a review from a team as a code owner November 12, 2025 10:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amartyasinha amartyasinha force-pushed the fix-missing-architecture-var branch from 3ff891f to c5032be Compare November 12, 2025 10:04
@amartyasinha amartyasinha changed the title Add default value of cifmw_architecture_repo [cifmw_setup] Add default value of cifmw_architecture_repo Nov 12, 2025
rebtoor
rebtoor requested changes Nov 12, 2025
View reviewed changes
@amartyasinha amartyasinha force-pushed the fix-missing-architecture-var branch from c5032be to 4b55e37 Compare November 12, 2025 10:17
@amartyasinha amartyasinha requested a review from rebtoor November 12, 2025 10:23
@evallesp evallesp enabled auto-merge (rebase) November 12, 2025 10:33
@amartyasinha @rebtoor
[cifmw_setup] Add default value of cifmw_architecture_repo
02e6981 
Since cifmw_setup role is often used in playbooks outside of ci-framework, it causes group_vars to not be included and causing missing variables error.

Signed-off-by: Amartya Sinha <[email protected]>
@rebtoor rebtoor force-pushed the fix-missing-architecture-var branch from 4b55e37 to 02e6981 Compare November 12, 2025 12:41
@danpawlik
Copy link
Contributor

danpawlik commented Nov 12, 2025

I'm against that.
It should be using var from group_vars. If that does not use it, we need to fix it not make something that would be reverted later.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Nov 12, 2025 •
edited
Loading

I'm against that. It should be using var from group_vars. If that does not use it, we need to fix it not make something that would be reverted later.

This is actually a partial revert, as it is blocking integration pipeline, instead of going for an entire revert.

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 12, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fa08c0265df6467e8d63ee05d66da8be

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 00s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 00s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 07s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 3h 00m 50s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test TIMED_OUT in 31m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 19s
✔️ build-push-container-cifmw-client SUCCESS in 16m 58s
✔️ cifmw-molecule-cifmw_setup SUCCESS in 2m 27s

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Nov 13, 2025

Closing as another fix worked. Partial revert not required.

auto-merge was automatically disabled November 13, 2025 07:51

Pull request was closed

@amartyasinha amartyasinha deleted the fix-missing-architecture-var branch January 9, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebtoor rebtoor rebtoor approved these changes

@evallesp evallesp evallesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amartyasinha @danpawlik @rebtoor @evallesp